Assignment 2#2
Open
SilviMargarian wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I wrote Python codes to read data in a given file and extract required information such as means, max and min values.
What did you learn from the changes you have made?
I learned how to make Python read files, write for loops and use built-in functions such as mean.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No, I wasn't thinking of any other approaches.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I wasn't sure how to properly use functions within another function (for example, using check_zeros() in conjunction with patient_summary() within detect_problems() function). But after going back and carefully reading what check_zeros() and the other function do and what kind of arguments they take, I was able to figure it out.
How were these changes tested?
These changes were tested using examples. I was hoping to get the expected output.
A reference to a related issue in your repository (if applicable)
Not applicable.
Checklist